Repository navigation
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try the Wiz Code extension for VS Code, JetBrains, or Visual Studio. |
|
@SelaseKay Sorry for the duplicated PR, can you explain why this one is stale ? |
|
What's delaying this pr? |
|
Hi, |
…sion The JVM target was chosen by comparing the AGP major version and the android.builtInKotlin flag. AGP registers the kotlin extension when built-in Kotlin is on, so use that. When the extension is absent, Flutter still applies the Kotlin plugin after this script, and the target is set then. Apps that leave built-in Kotlin off, including Flutter 3.44 through 3.46, keep configuring.
e373a8c to
bfcaf71
Compare
SelaseKay
changed the title
Description
The built-in Kotlin migration in #18922 sets each plugin's Kotlin JVM target in one of two ways. When built-in Kotlin is on, AGP has already registered the
kotlinextension and the target is set on it. When built-in Kotlin is off, Flutter appliesorg.jetbrains.kotlin.androidafter the plugin script, and the target is set then.That choice was made by reading the AGP major version. This pull request drops the version check. If the
kotlinextension is already registered, the target is set immediately. If it is not, the existingplugins.withIdpath still runs. Apps that leaveandroid.builtInKotlinoff keep configuring, including Flutter 3.44 through 3.46, where turning built-in Kotlin on is not supported.#18355 removed that branch outright. Replaying it on current main fails configuration whenever
android.builtInKotlinis false, which is still the setting in these examples and in the Flutter template. The version check is what this rebase removes. The fallback stays.AGP 9.3.1, Gradle 9.5.0, Kotlin 2.4.20, and the Flutter 3.44 / Dart 3.12 floor are unchanged.
Related Issues
Rebases #18355 onto current main after #18922.
Related: #18944
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
Apps that set
android.builtInKotlin=false, and apps on AGP older than 9, still take theplugins.withIdpath. No Gradle files in an app have to change.Test plan
android.builtInKotlin=trueand the plugin's JVM target matches its Java version. Examples andtests/androidstay onfalse, so CI only exercises the fallback.